Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch OverflowError for "out of range" datetimes #5546

Merged
merged 2 commits into from Oct 31, 2017

Conversation

sbchisholm
Copy link
Contributor

@sbchisholm sbchisholm commented Oct 30, 2017

Closes: #5545

I would expect that this invalid value would raise a ValidationError but instead it raises an OverflowError.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Yep. Good test. We should probably catch that and convert.

@sbchisholm Fancy adding that?

@sbchisholm
Copy link
Contributor Author

sbchisholm commented Oct 30, 2017

@carltongibson sure thing.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Lovely. Thank you.

@carltongibson carltongibson added this to the 3.7.2 milestone Oct 31, 2017
@carltongibson carltongibson changed the title Add "out of range" datetime test for issue #5545 Catch OverflowError for "out of range" datetimes Oct 31, 2017
@carltongibson carltongibson merged commit 93e75ec into encode:master Oct 31, 2017
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants