Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rest_framework.compat import test #5567

Merged
merged 2 commits into from Nov 6, 2017
Merged

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Nov 6, 2017

Adds a test case for #5566

Ryan P Kilby and others added 2 commits November 6, 2017 09:56
Fixed some regressions where compat was imported during app loading and
led to importing django.contrib.auth.models which ended in a
`AppRegistryNotReady` exception.
@rpkilby
Copy link
Member Author

rpkilby commented Nov 6, 2017

Alright, I cherry picked your commit @xordoquy, and things look good locally. Currently waiting for the build to complete.

@xordoquy
Copy link
Collaborator

xordoquy commented Nov 6, 2017

ace !

@xordoquy
Copy link
Collaborator

xordoquy commented Nov 6, 2017

Looks like we're good now !

@carltongibson
Copy link
Collaborator

OK. Everyone, well done.

@carltongibson carltongibson added this to the v3.7.3 milestone Nov 6, 2017
@edmorley
Copy link
Contributor

edmorley commented Nov 6, 2017

Many thanks :-)

@felixxm
Copy link
Contributor

felixxm commented Nov 6, 2017

Thanks and sorry for this bug.

@xordoquy
Copy link
Collaborator

xordoquy commented Nov 6, 2017

@felixxm no need to apologize, it is a very non obvious side effect that no-one did see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants