Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ulrparse compatability shim; use six instead #5579

Merged
merged 1 commit into from Nov 9, 2017
Merged

Remove ulrparse compatability shim; use six instead #5579

merged 1 commit into from Nov 9, 2017

Conversation

jdufresne
Copy link
Contributor

@jdufresne jdufresne commented Nov 9, 2017

The urlparse shim in compat.py duplicates Django's bundled six. Can rely on upstream instead of duplicating their works. Unifies shim with other files already using six.

The urlparse shim in compat.py duplicates Django's bundled six. Can rely
on upstream instead of duplicating their works. Unifies shim with other
files already using six.
@xordoquy
Copy link
Collaborator

xordoquy commented Nov 9, 2017

Yup, that was there to support Django version that didn't had this. No need for it any longer.

@xordoquy xordoquy merged commit 9234ac5 into encode:master Nov 9, 2017
1 check passed
@carltongibson carltongibson added this to the v3.7.4 milestone Nov 9, 2017
@jdufresne jdufresne deleted the urllib branch Nov 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants