Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readme, add to CI #5625

Merged
merged 4 commits into from Nov 27, 2017
Merged

Fix readme, add to CI #5625

merged 4 commits into from Nov 27, 2017

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Nov 25, 2017

Adds a CI build for checking README markdown => restructuredtext conversion.

Fixes #3817.

Requires a few changes:

  • The HTML that centers the sponsor images needs to be removed.
  • The italics around funding links needs to be removed
  • Add hr between image and subsequent section

@rpkilby rpkilby force-pushed the fix-readme branch 6 times, most recently from fc7700a to 57b8050 Compare Nov 26, 2017
rpkilby added 2 commits Nov 26, 2017
This loses the image centering, but can be converted to RST.
- Links do not render correctly inside italics
- Add hr between image caption and section, fixes markup on older
  versions of pandoc.
@carltongibson carltongibson added this to the v3.7.4 milestone Nov 27, 2017
Copy link
Collaborator

@carltongibson carltongibson left a comment

Nice work @rpkilby!

@carltongibson carltongibson merged commit fc6b192 into encode:master Nov 27, 2017
1 check passed
@rpkilby rpkilby deleted the fix-readme branch Nov 27, 2017
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
* Add readme build to CI

* Fix pandoc import in setup.py

* Replace sponsor HTML with markdown

This loses the image centering, but can be converted to RST.

* Fix README RST conversion

- Links do not render correctly inside italics
- Add hr between image caption and section, fixes markup on older
  versions of pandoc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants