Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema to the ObtainAuthToken view #5676

Closed
wants to merge 1 commit into from

Conversation

scardine
Copy link
Contributor

@scardine scardine commented Dec 17, 2017

Description

The username and password fields were not described in the document created by include_docs_urls. This fixes it for me, don't know if there is a better way to do it.

Add encoding parameter to ManualSchema
@carltongibson
Copy link
Collaborator

carltongibson commented Dec 18, 2017

Hi @scardine.

There's two things going on here: adding the ManualFields schema to the ObtainAuthToken view, and adding the encoding parameter to ManualFields. We should handle these separately.

Adding the fields to the ObtainAuthToken view seems reasonable.

Can you make a different PR handling the encoding please? (Docs and tests there would be needed.)

Also we have a lint failure

@scardine
Copy link
Contributor Author

scardine commented Dec 18, 2017

Fair enough, I will cleanup and submit again.

@carltongibson
Copy link
Collaborator

carltongibson commented Feb 5, 2018

Hi @scardine. I fixed the lint error and added the docs for the new encoding parameter. I think that's good enough. Thanks for the input!

@carltongibson carltongibson added this to the 3.8 Release milestone Feb 5, 2018
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Add encoding parameter to ManualSchema

Closes encode#5676

* Fixed lint errors
* Added docs for ManualSchema encoding parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants