Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test staticfiles #5701

Merged
merged 4 commits into from Jan 2, 2018
Merged

Test staticfiles #5701

merged 4 commits into from Jan 2, 2018

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Dec 21, 2017

Test for #5692. This is committed in the same vein as #5700, which is based off of d12005c (added the dist build). Tests will fail locally (as expected), but the merge commit in CI causes this to pass (as expected, since master contains the fixed MANIFEST.in).

By default ManifestStaticFilesStorage is strict in that missing static files will raise exceptions during the collectstatic call. The missing .woff2 and .ico files would have been caught by this.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Yep. Looks good. 👍

@carltongibson carltongibson added this to the 3.8 Release milestone Jan 2, 2018
@carltongibson carltongibson merged commit 68519c0 into encode:master Jan 2, 2018
1 check passed
@rpkilby rpkilby deleted the test-staticfiles branch Jan 3, 2018
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
* Remove 'MIDDLEWARE_CLASSES' compat setting

* Remove 'django.setup()' compat import

* Move '--no-pkgroot' handling to conftest

* Add staticfiles handling to dist build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants