Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HTML inputs for dict/list fields #5702

Merged
merged 1 commit into from Jan 2, 2018

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Dec 22, 2017

ListField & DictField do not seem to have proper HTML form support. Until they do, it would make sense to render a disabled form input, similar to how nested list serializers are currently handled.

Is there any reason not to disable these inputs?

Additionally, I would add tests for this, but I don't see any relevant tests for serializer form rendering.

@rpkilby rpkilby added this to the 3.8 Release milestone Dec 22, 2017
Copy link
Collaborator

@carltongibson carltongibson left a comment

Given current limitations, I agree that disabling these fields is the best approach.

The solution here is for users to provide their own templates adding whatever widgets are needed for their use-case. That's out of scope for core as of now. (Would make some good blog posts though.)

@carltongibson carltongibson merged commit b7ed645 into encode:master Jan 2, 2018
1 check passed
@rpkilby rpkilby deleted the disable-composite-inputs branch Jan 3, 2018
@rpkilby rpkilby mentioned this pull request Jan 2, 2019
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants