Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show hidden fields in OPTIONS responses #5854

Merged

Conversation

craigds
Copy link
Contributor

@craigds craigds commented Mar 1, 2018

HiddenField is meant to be entirely hidden, but we discovered it showing up in OPTIONS requests in actions.

This fixes the problem by skipping HiddenField instances in SimpleMetadata.get_serializer_info, and adds a test.

HiddenField is meant to be hidden, but we discovered it showing up in OPTIONS requests
@tomchristie
Copy link
Member

tomchristie commented Mar 23, 2018

Fair enough

@tomchristie tomchristie merged commit a507277 into encode:master Mar 23, 2018
1 check passed
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
HiddenField is meant to be hidden, but we discovered it showing up in OPTIONS requests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants