Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Render descriptions correctly #5869

Merged
merged 1 commit into from Apr 20, 2018
Merged

Conversation

beruic
Copy link
Contributor

@beruic beruic commented Mar 9, 2018

This fixes #5715. Descriptions in the docs view not render HTML like it is done anywhere else.

@carltongibson
Copy link
Collaborator

carltongibson commented Mar 13, 2018

Hi @beruic.

Thanks for the input here. I'm not sure we want to go with safe here. (Maybe it's fine but it needs a decent review.)

I'll mark it for v3.9, where we'll target a few related issues here, and we'll decide either way for then. In the meantime you can override the template by putting your version in place to be loaded first.

@carltongibson carltongibson added this to the 3.9 Release milestone Mar 13, 2018
@beruic
Copy link
Contributor Author

beruic commented Mar 13, 2018

Well, if we are not going with safe here, it should be removed the other places too.

@beruic
Copy link
Contributor Author

beruic commented Mar 14, 2018

Hint: A lot of the places where |safe must be removed in templates (if that is decided) has the class help-block.

@carltongibson carltongibson modified the milestones: 3.9 Release, 3.8.3 Release Apr 20, 2018
Copy link
Collaborator

@carltongibson carltongibson left a comment

Hi @beruic. You're correct that given other uses we can take this one now. (We'll do a bigger review as part of 3.9.)

Thanks for the effort!

@carltongibson carltongibson merged commit 4260531 into encode:master Apr 20, 2018
1 check passed
@beruic beruic deleted the patch-1 branch Apr 23, 2018
@rpkilby rpkilby modified the milestones: 3.8.3 Release, 3.9 Release Aug 29, 2018
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
To allow embedded HTML, and make consistent with other usages.

Fixes encode#5715.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants