Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add admin to installed apps to avoid test failures #5870

Merged
merged 1 commit into from Mar 9, 2018

Conversation

cgopalan
Copy link
Contributor

@cgopalan cgopalan commented Mar 9, 2018

The tests look for the "admin" app in the list of apps. If not present, running runtests.py gives the following error:

LookupError: No installed app with label 'admin'.

Adding admin to INSTALLED_APPS fixes it.

OS : Windows 10
Python version: 3.6.4
Django version: 2.1

The tests look for the "admin" app in the list of apps. If not present, running `runtests.py` gives the following error:
```
LookupError: No installed app with label 'admin'.
```
Adding admin to `INSTALLED_APPS` fixes it.
@xordoquy
Copy link
Collaborator

xordoquy commented Mar 9, 2018

Thanks for the fix.
I also saw your emails. Using Django's master will make things harder for you because some times you'll find things are reverted so it may be hard to follow.

@xordoquy xordoquy merged commit e3544f9 into encode:master Mar 9, 2018
1 check passed
@cgopalan
Copy link
Contributor Author

cgopalan commented Mar 9, 2018

Thanks for the merge! DRF is awesome! Yeah agreed - the master branch is not the best. Glad it worked out here though. I will use stable versions for bigger changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants