Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use old url_name behavior in route decorators #5915

Merged
merged 2 commits into from Apr 4, 2018

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Apr 4, 2018

  • Change deprectaed *_route decorators to use old behavior for generating url_name.
  • Update changelog to reflect that the action decorator has generates url_name differently, while the *_route decorators are unchanged.

ref #5705

@rpkilby
Copy link
Member Author

@rpkilby rpkilby commented Apr 4, 2018

cc @carltongibson, @xordoquy

@xordoquy
Copy link
Collaborator

@xordoquy xordoquy commented Apr 4, 2018

just ❤️

Copy link
Contributor

@auvipy auvipy left a comment

(Y)

@carltongibson
Copy link
Collaborator

@carltongibson carltongibson commented Apr 4, 2018

OK. 3.8.1 later on.

@carltongibson carltongibson added this to the 3.8.1 Release milestone Apr 4, 2018
@carltongibson carltongibson merged commit cba426b into encode:master Apr 4, 2018
1 check passed
@rpkilby rpkilby deleted the fix-route-url_name branch Apr 4, 2018
@carltongibson
Copy link
Collaborator

@carltongibson carltongibson commented Apr 4, 2018

It's on PyPI now. Thanks @xordoquy and @rpkilby!

pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this issue Nov 17, 2020
* Wrap action decorator for old url_name behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants