Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add missing argument 'detail' to Route #5920

Merged
merged 1 commit into from Apr 5, 2018

Conversation

michael-k
Copy link
Contributor

@michael-k michael-k commented Apr 5, 2018

The namedtuple Route requires detail to be specified, otherwise it fails with: TypeError: __new__() missing 1 required positional argument: 'detail'.

Description

Since PR #5705 Route() requires argument detail. It was added to the SimpleRouter, but forgotten in an example in the documentation.

The namedtuple Route requires `detail` to be specified, otherwise it
fails with:
`TypeError: __new__() missing 1 required positional argument: 'detail'`

See https://github.com/encode/django-rest-framework/pull/5705/files#diff-88b0cad65f9e1caad64e0c9bb44615f9R34
Copy link
Collaborator

@carltongibson carltongibson left a comment

Yep. Good. Thanks!

@carltongibson carltongibson added this to the 3.8.2 Release milestone Apr 5, 2018
@carltongibson carltongibson merged commit ffac61c into encode:master Apr 5, 2018
@michael-k michael-k deleted the docs-route-detail branch Apr 5, 2018
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
The namedtuple Route requires `detail` to be specified, otherwise it
fails with:
`TypeError: __new__() missing 1 required positional argument: 'detail'`

See https://github.com/encode/django-rest-framework/pull/5705/files#diff-88b0cad65f9e1caad64e0c9bb44615f9R34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants