Rename base_name => basename for consistency's sake #5990
Conversation
|
Seems fair enough, yup. Given that we work against master we typically don't pull in deprecation changes until we're confident that the next release will be one of the major version bumps. I guess we could leave this on hold until we're getting ready to release 3.9 |
|
Makes sense to me. Adding it to the milestone. |
| @@ -65,7 +65,7 @@ For example, you can append `router.urls` to a list of existing views… | |||
|
|
|||
| urlpatterns += router.urls | |||
|
|
|||
| Alternatively you can use Django's `include` function, like so… | |||
| Alternatively you can use Django's `include` function, like so... | |||
There was a problem hiding this comment.
Why don't you like …?
There was a problem hiding this comment.
Oh - that was unintentional. I have a plugin that converts magic quotes to their ascii equivalent, but it also catches ellipses apparently.
|
This is very confusing at the moment. The online docs already talk only about I understand that the online docs are not versioned like the django ones, but I think in that case they should be either clearly marked as DEV, or they should follow the latest stable release, used in production environments... |
|
@minusf Yes. That's not great. A recent docs roll-out will have updated this. I'll see if I can patch-up something correct for the time before v3.9. |
|
@minusf I've redeployed the docs. They look correct for v3.8 now. Thanks for pinging in the issue. |
|
thanks for looking into this. |
djangorestframework v3.9 deprecated the keyword argument "base_name" for routers. The old name works up to djangorestframework 3.10, but fails later. See encode/django-rest-framework#5990
* Rename base_name => basename for consistency * Update tests to use basename
Changed on DRF 3.12.x and related to PR encode/django-rest-framework#5990
Name change introduced here encode/django-rest-framework#5990
Name change introduced here encode/django-rest-framework#5990
The viewsets and routers use both
base_nameandbasename. It would be nice if this were consistent.I've deprecated
base_namein favor ofbasename, andget_default_base_namein favor ofget_default_basename. Fortunately, the deprecation is fairly straightforward.Router.registerneeds to handle both arguments appropriately (fallback to the old value if present, raise deprecation warnings, complain if both arguments are provided)