Rename base_name => basename for consistency's sake #5990
Seems fair enough, yup.
Given that we work against master we typically don't pull in deprecation changes until we're confident that the next release will be one of the major version bumps. I guess we could leave this on hold until we're getting ready to release 3.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very confusing at the moment. The online docs already talk only about
I understand that the online docs are not versioned like the django ones, but I think in that case they should be either clearly marked as DEV, or they should follow the latest stable release, used in production environments...
djangorestframework v3.9 deprecated the keyword argument "base_name" for routers. The old name works up to djangorestframework 3.10, but fails later. See encode/django-rest-framework#5990
[Deprecate] (https://www.django-rest-framework.org/community/release-notes/#390) the Router.register base_name argument in favor of basename. [#5990] (encode/django-rest-framework#5990)
Changed on DRF 3.12.x and related to PR encode/django-rest-framework#5990