Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DjangoObjectPermissionsFilter #6075

Merged
merged 1 commit into from Oct 2, 2018

Conversation

rpkilby
Copy link
Member

@rpkilby rpkilby commented Jul 10, 2018

From the discussion in #6038, the objective is to move django-guardian integrations out of the core framework and into a 3rd-party package. Motivating factors are in this comment.

This PR is fairly straightforward, as DjangoObjectPermissionsFilter is the only direct integration. DjangoObjectPermissions just hooks into the object-level permissions and isn't directly dependent.

3rd-party package: https://github.com/rpkilby/django-rest-framework-guardian

@rpkilby rpkilby added this to the 3.9 Release milestone Jul 10, 2018
@rpkilby
Copy link
Member Author

rpkilby commented Jul 10, 2018

Adding to the 3.9 milestone to ensure it's reviewed.

@carltongibson carltongibson force-pushed the deprecate-django-guardian branch from a68d266 to 2667635 Compare Oct 2, 2018
@carltongibson carltongibson merged commit 6618338 into encode:master Oct 2, 2018
1 check passed
@rpkilby rpkilby deleted the deprecate-django-guardian branch Oct 2, 2018
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants