Fix action support for ViewSet suffixes #6081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2018
rpkilby
force-pushed
the
action-suffix
branch
from
4db7649
to
1581346
Compare
|
This is ready for review now. No functional changes since the initial PR - just added tests and made minor docs adjustments. |
|
Thanks again to @blueyed for raising the issue! |
|
Good work @rpkilby. Thanks for all your effort. I will take a look next week, or so. |
Removes the newly introduced `action.name` in favor of leveraging the View's `.get_view_name()` method, which supports both name and suffix.
carltongibson
force-pushed
the
action-suffix
branch
from
1581346
to
ca03600
Compare
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* Add suffix support for actions Removes the newly introduced `action.name` in favor of leveraging the View's `.get_view_name()` method, which supports both name and suffix. * Fix view description func docstrings * Test action decorator name & suffix kwargs * Adjust 'extra action' docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Followup to #5605, fixing
actionsupport for ViewSet suffixes. This supersedes #6079.Removing the
nameattribute isn't an issue, since it hasn't been released as part of the public API.TODO:
cc @blueyed