Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle models without .objects manager in ModelSerializer. #6111

Merged
merged 2 commits into from Aug 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions rest_framework/serializers.py
Expand Up @@ -937,14 +937,14 @@ def create(self, validated_data):
many_to_many[field_name] = validated_data.pop(field_name)

try:
instance = ModelClass.objects.create(**validated_data)
instance = ModelClass._default_manager.create(**validated_data)
except TypeError:
tb = traceback.format_exc()
msg = (
'Got a `TypeError` when calling `%s.objects.create()`. '
'Got a `TypeError` when calling `%s._default_manager.create()`. '
'This may be because you have a writable field on the '
'serializer class that is not a valid argument to '
'`%s.objects.create()`. You may need to make the field '
'`%s._default_manager.create()`. You may need to make the field '
'read-only, or override the %s.create() method to handle '
'this correctly.\nOriginal exception was:\n %s' %
(
Expand Down
21 changes: 20 additions & 1 deletion tests/test_model_serializer.py
Expand Up @@ -102,6 +102,13 @@ class Issue3674ChildModel(models.Model):
value = models.CharField(primary_key=True, max_length=64)


class Issue6110TestModel(models.Model):
"""Model without .objects manager."""

name = models.CharField(max_length=64)
all_objects = models.Manager()


class UniqueChoiceModel(models.Model):
CHOICES = (
('choice1', 'choice 1'),
Expand All @@ -126,7 +133,7 @@ class Meta:
})
serializer.is_valid()

msginitial = 'Got a `TypeError` when calling `OneFieldModel.objects.create()`.'
msginitial = 'Got a `TypeError` when calling `OneFieldModel._default_manager.create()`.'
with self.assertRaisesMessage(TypeError, msginitial):
serializer.save()

Expand Down Expand Up @@ -1224,3 +1231,15 @@ class Meta:
""")
self.maxDiff = None
self.assertEqual(unicode_repr(TestSerializer()), expected)


class Issue6110Test(TestCase):
def test_model_serializer_custom_manager(self):

class TestModelSerializer(serializers.ModelSerializer):
class Meta:
model = Issue6110TestModel
fields = ('name',)

instance = TestModelSerializer().create({'name': 'test_name'})
self.assertEqual(instance.name, 'test_name')