Fix CSRF cookie check failure when using session auth #6113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1.6+ Test included. Fixes encode#6088
Codecov Report
@@ Coverage Diff @@
## master #6113 +/- ##
==========================================
+ Coverage 96.17% 96.18% +<.01%
==========================================
Files 128 128
Lines 17614 17624 +10
Branches 1459 1459
==========================================
+ Hits 16941 16951 +10
Misses 465 465
Partials 208 208 |
|
Looks good to me. Thanks! |
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
…1.6+ (encode#6113) Test included. Fixes encode#6088
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CSRF failures when using cookie-based csrf with session auth and django 1.11.6+.
Test included (fails with old DRF and passes with this fix). Fixes #6088