Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSRF cookie check failure when using session auth #6113

Merged
merged 1 commit into from Aug 7, 2018

Conversation

craigds
Copy link
Contributor

@craigds craigds commented Aug 7, 2018

Fixes CSRF failures when using cookie-based csrf with session auth and django 1.11.6+.

Test included (fails with old DRF and passes with this fix). Fixes #6088

@codecov-io
Copy link

codecov-io commented Aug 7, 2018

Codecov Report

Merging #6113 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6113      +/-   ##
==========================================
+ Coverage   96.17%   96.18%   +<.01%     
==========================================
  Files         128      128              
  Lines       17614    17624      +10     
  Branches     1459     1459              
==========================================
+ Hits        16941    16951      +10     
  Misses        465      465              
  Partials      208      208

@tomchristie
Copy link
Member

tomchristie commented Aug 7, 2018

Looks good to me. Thanks!

@tomchristie tomchristie merged commit 81fa4b4 into encode:master Aug 7, 2018
1 check passed
@craigds craigds deleted the fix-session-csrf-failure branch Oct 25, 2018
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSRFCheck fails from csrf cookie with django 1.11
3 participants