Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure serializer and field validators support both lists and tuples #6282

Merged
merged 1 commit into from Feb 19, 2019

Conversation

Projects
None yet
5 participants
@fengsi
Copy link
Contributor

fengsi commented Oct 26, 2018

This PR fixes #6280.

@fengsi fengsi force-pushed the fengsi:6280 branch 2 times, most recently from 682dfea to c262c5e Oct 26, 2018

@fengsi fengsi changed the title Allow field `validators` parameter to be iterable (#6280) Allow field `validators` parameter to be iterables (#6280) Oct 26, 2018

@fengsi fengsi force-pushed the fengsi:6280 branch from c262c5e to 04206b9 Oct 26, 2018

@fengsi fengsi referenced this pull request Oct 26, 2018

Closed

`validators` parameter in field cannot deal with `tuple` #6280

5 of 6 tasks complete
@rpkilby
Copy link
Member

rpkilby left a comment

👍

@rpkilby rpkilby added this to the 3.9.1 Release milestone Oct 26, 2018

Show resolved Hide resolved tests/test_fields.py
Show resolved Hide resolved rest_framework/serializers.py

@rpkilby rpkilby changed the title Allow field `validators` parameter to be iterables (#6280) Ensure serializer and field support both lists and tuples Oct 26, 2018

@rpkilby rpkilby changed the title Ensure serializer and field support both lists and tuples Ensure serializer and field validators support both lists and tuples Oct 26, 2018

@fengsi fengsi force-pushed the fengsi:6280 branch 2 times, most recently from cb0e276 to 9d98c23 Oct 31, 2018

@fengsi fengsi changed the title Ensure serializer and field validators support both lists and tuples Allow field `validators` parameter to be iterables Oct 31, 2018

@fengsi fengsi changed the title Allow field `validators` parameter to be iterables Ensure serializer and field validators support both lists and tuples Oct 31, 2018

@auvipy

auvipy approved these changes Feb 14, 2019

@fengsi fengsi force-pushed the fengsi:6280 branch from 9d98c23 to dab441a Feb 14, 2019

@carltongibson carltongibson self-requested a review Feb 14, 2019

@fengsi fengsi force-pushed the fengsi:6280 branch from dab441a to e0758cd Feb 15, 2019

@carltongibson carltongibson force-pushed the fengsi:6280 branch from e0758cd to 9bc5b29 Feb 19, 2019

@carltongibson
Copy link
Collaborator

carltongibson left a comment

Hi @fengsi. Thanks for this.
I rebased and made a few cosmetic changes.

👍

@carltongibson carltongibson merged commit 1ece516 into encode:master Feb 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@fengsi fengsi deleted the fengsi:6280 branch Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.