Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure serializer and field validators support both lists and tuples #6282

Merged
merged 1 commit into from Feb 19, 2019
Merged

Conversation

fengsi
Copy link
Contributor

@fengsi fengsi commented Oct 26, 2018

This PR fixes #6280.

@fengsi fengsi changed the title Allow field validators parameter to be iterable (#6280) Allow field validators parameter to be iterables (#6280) Oct 26, 2018
Copy link
Member

@rpkilby rpkilby left a comment

👍

@rpkilby rpkilby added this to the 3.9.1 Release milestone Oct 26, 2018
tests/test_fields.py Show resolved Hide resolved
rest_framework/serializers.py Show resolved Hide resolved
@rpkilby rpkilby changed the title Allow field validators parameter to be iterables (#6280) Ensure serializer and field support both lists and tuples Oct 26, 2018
@rpkilby rpkilby changed the title Ensure serializer and field support both lists and tuples Ensure serializer and field validators support both lists and tuples Oct 26, 2018
@fengsi fengsi changed the title Ensure serializer and field validators support both lists and tuples Allow field validators parameter to be iterables Oct 31, 2018
@fengsi fengsi changed the title Allow field validators parameter to be iterables Ensure serializer and field validators support both lists and tuples Oct 31, 2018
auvipy
auvipy approved these changes Feb 14, 2019
@carltongibson carltongibson self-requested a review Feb 14, 2019
Copy link
Collaborator

@carltongibson carltongibson left a comment

Hi @fengsi. Thanks for this.
I rebased and made a few cosmetic changes.

👍

@carltongibson carltongibson merged commit 1ece516 into encode:master Feb 19, 2019
1 check passed
@fengsi fengsi deleted the 6280 branch Mar 5, 2019
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validators parameter in field cannot deal with tuple
5 participants