Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composable permissions #6299

Merged
merged 1 commit into from Nov 27, 2018

Conversation

Projects
None yet
2 participants
@xordoquy
Copy link
Collaborator

xordoquy commented Nov 1, 2018

In some cases we end with an operation between two OperandHolder.
This didn't work as it didn't knew how to deal with | or &
This fixes by adding those operations.

Closes #6296

@carltongibson carltongibson added this to the 3.9.1 Release milestone Nov 5, 2018

@carltongibson
Copy link
Collaborator

carltongibson left a comment

Looks good. Thanks for the quick fix!

@xordoquy xordoquy force-pushed the xordoquy/fix_composable_permissions branch from bc04a82 to e8c7e7e Nov 27, 2018

Fix composable permissions
In some cases we end with an operation between two `OperandHolder`.
This didn't work as it didn't knew how to deal with | or &
This fixes by adding those operations.

@xordoquy xordoquy force-pushed the xordoquy/fix_composable_permissions branch from e8c7e7e to 7457421 Nov 27, 2018

@xordoquy xordoquy merged commit 11edf57 into master Nov 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@xordoquy xordoquy deleted the xordoquy/fix_composable_permissions branch Nov 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.