Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'request_forms' block to base.html #6340

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
4 participants
@ababic
Copy link
Contributor

ababic commented Nov 28, 2018

Supersedes: #6337

Resolves: #6339

On advice from @tomchristie, I've deliberately left indentation as it is.

I've also simplified things by only adding a single block instead of three. While not quite as helpful for users wanting to override other bits within the content block, it's a smaller change with less of a maintenance commitment.

Andy Babic
@rpkilby

This comment has been minimized.

Copy link
Member

rpkilby commented Nov 28, 2018

Thanks for the updated PR. As @tomchristie said, will need to think on it.

@carltongibson
Copy link
Collaborator

carltongibson left a comment

As this stands it's seems OK to me.

@carltongibson carltongibson requested a review from tomchristie Jan 21, 2019

@tomchristie

This comment has been minimized.

Copy link
Member

tomchristie commented Jan 24, 2019

Yup, looks good.

@carltongibson
Copy link
Collaborator

carltongibson left a comment

Awesome. Thanks for the input.

Welcome aboard @ababic! 💃

@carltongibson carltongibson merged commit 87ade87 into encode:master Jan 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.