Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added testing against Django 2.2a1. #6422

Merged
merged 2 commits into from Jan 31, 2019
Merged

Conversation

auvipy
Copy link
Contributor

@auvipy auvipy commented Jan 27, 2019

do not merge

@carltongibson carltongibson changed the title [WIP] added django 2.2a1 support Added testing against Django 2.2a1. Jan 31, 2019
Copy link
Collaborator

@carltongibson carltongibson left a comment

Hi @auvipy. Thanks for this.
I adjusted slightly and will merge now with Django 2.2 as an allowed failure.

@carltongibson carltongibson merged commit 2b62941 into encode:master Jan 31, 2019
1 check passed
@auvipy auvipy deleted the dj22 branch Jan 31, 2019
@auvipy
Copy link
Contributor Author

auvipy commented Jan 31, 2019

thanks!! :D

@timgraham
Copy link

timgraham commented Jan 31, 2019

I think the issue is that the CustomToken model (without migrations) can't have a related to the User (with migrations) as discussed in django/django@fcfb730.

@auvipy
Copy link
Contributor Author

auvipy commented Feb 1, 2019

I see!! thanks, Tim for pointing!!

pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
* Added testing against Django 2.2a1.
* Allow failures for Django 2.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants