Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.2 compat #6455

Merged
merged 6 commits into from Feb 14, 2019

Conversation

Projects
None yet
2 participants
@carltongibson
Copy link
Collaborator

carltongibson commented Feb 14, 2019

No description provided.

carltongibson added some commits Feb 14, 2019

Fix search filter tests against Django 2.2.
Django 2.2 enables foreign key constraint checking on SQLite.
@tomchristie

This comment has been minimized.

Copy link
Member

tomchristie commented Feb 14, 2019

Want to talk me through what's new here? What's with the model & migration?

@carltongibson

This comment has been minimized.

Copy link
Collaborator Author

carltongibson commented Feb 14, 2019

As per Tim's #6422 (comment) models with FKs to models with migrations must have migrations.

So... just moving things around. It's only the CustomToken model that is the issue.

But I haven't got it quite right yet, and it's not reproducing for me locally. (So fun™)

@carltongibson carltongibson force-pushed the carltongibson:django-2.2-compat branch 3 times, most recently from 5491bfd to d050d16 Feb 14, 2019

@carltongibson

This comment has been minimized.

Copy link
Collaborator Author

carltongibson commented Feb 14, 2019

OK, spotted this. There's also a Tag model with FK to ContentType (in test_relations_generic.py). I'll update that too and we should be good.

carltongibson added some commits Feb 14, 2019

Add migration for CustomToken test model.
Move authentication tests to sub-app to enable this.

@carltongibson carltongibson force-pushed the carltongibson:django-2.2-compat branch from d050d16 to 99a32b3 Feb 14, 2019

@carltongibson carltongibson merged commit 65f5c11 into encode:master Feb 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@carltongibson carltongibson deleted the carltongibson:django-2.2-compat branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.