Skip to content

Introduce RemovedInDRF…Warning classes to simplify deprecations. - #6480

Merged
carltongibson merged 1 commit into
encode:masterfrom
carltongibson:simplify-deprecations
Mar 3, 2019
Merged

carltongibson merged 1 commit into
encode:masterfrom
carltongibson:simplify-deprecations

Conversation

@carltongibson

Copy link
Copy Markdown
Collaborator

Closes #6290.

@carltongibson carltongibson added this to the 3.9.2 Release milestone Mar 1, 2019
@carltongibson

Copy link
Copy Markdown
Collaborator Author

@tomchristie @rpkilby I quite like this. It adds a small amount of code by makes handling deprecations a lot simpler.

  • Branch for 3.10, delete RemovedInDRF310Warning, delete all the code that breaks.
    • Note that for release announcement.
  • Bump RemovedInDRF311Warning to DeprecationWarning.
    • Note for release announcement.

Much harder to miss anything.

Let me know what you think. If we're happy with it I'll merge.

Either way, this wraps up 3.9.2 🎉 I'll prepare the release over the weekend. 💃

@rpkilby

rpkilby commented Mar 1, 2019

Copy link
Copy Markdown
Contributor

I'm definitely in favor of this.

@lovelydinosaur

Copy link
Copy Markdown
Member

@auvipy I think I've asked this before, but please don't use the PR approval unless you're actively involved in a ticket. (As it happens I'd rather it was only enabled for maintainers or by-request-from-maintainers, but GitHub doesn't allow us to turn the functionality off.)

@lovelydinosaur lovelydinosaur left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Thanks @carltongibson!

@auvipy

auvipy commented Mar 3, 2019

Copy link
Copy Markdown
Collaborator

@tomchristie I don't use PR approve button unless I go through it fully. I don't know how you manage to do this in an open source project? respectfully disagree with you on this point.

@carltongibson

Copy link
Copy Markdown
Collaborator Author

Hi @auvipy.

To be honest I too find it distracting that you approve PRs without adding to the conversation.

For me it would be better if you spent your time looking at less PRs but reviewed them fully, with comments and improvements etc. There’s a massive backlog around the ecosystem so plenty to do there.

Then if there were some PRs that you just approved that would tell something. As it stands it your tick isn’t often acting as a marker, since it’s too quickly given, so it’s not serving as a guide as to whether to merge.

I hope that makes sense. It’s meant in a spirit of love and encouragement. Please think about it. Happy to chat off thread if you like. C.

@carltongibson
carltongibson merged commit 94593b3 into encode:master Mar 3, 2019
@carltongibson
carltongibson deleted the simplify-deprecations branch March 3, 2019 08:20
@auvipy

auvipy commented Mar 3, 2019

Copy link
Copy Markdown
Collaborator

@carltongibson I would really love to engage that way. I get paid for working with foss. so why not :)

@carltongibson

Copy link
Copy Markdown
Collaborator Author

@auvipy OK, send me an email. 👍

@auvipy

auvipy commented Mar 3, 2019

Copy link
Copy Markdown
Collaborator

definitely, I will. you just won my heart by your words Carlton <3

pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants