Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested write of non-relational fields #6916

Merged
merged 4 commits into from Oct 3, 2019

Conversation

tselepakis
Copy link
Contributor

@tselepakis tselepakis commented Sep 5, 2019

Description

Continuing work started in #6741 . This MR fixes dotted write and adds the related tests.

@tselepakis tselepakis changed the title Nested json serializer Fix nested write of non-relational fields Sep 5, 2019
Copy link
Member

@rpkilby rpkilby left a comment

This largely looks good to me, save some small nitpicks.

tests/test_serializer_nested.py Outdated Show resolved Hide resolved
tests/test_serializer_nested.py Outdated Show resolved Hide resolved
rest_framework/serializers.py Outdated Show resolved Hide resolved
rest_framework/serializers.py Outdated Show resolved Hide resolved
tests/test_serializer_nested.py Outdated Show resolved Hide resolved
* no need to change `raise_errors_on_nested_writes` signature
* declare nested-model outside of the test class
rpkilby
rpkilby approved these changes Sep 6, 2019
Copy link
Member

@kevin-brown kevin-brown left a comment

LGTM. Approving without merging.

@tselepakis
Copy link
Contributor Author

tselepakis commented Oct 3, 2019

Hi all, any chance on adding this in next release? We are stuck to 3.9.4 due to this issue. Do we have something pending?

@rpkilby
Copy link
Member

rpkilby commented Oct 3, 2019

Do we have something pending?

Was waiting for other members to review, but this is good to go.

@rpkilby rpkilby merged commit 30e56f6 into encode:master Oct 3, 2019
1 check passed
@auvipy
Copy link
Contributor

auvipy commented Oct 4, 2019

hope to see this in 3.10.x

@tselepakis
Copy link
Contributor Author

tselepakis commented Oct 4, 2019

Do we have something pending?

Was waiting for other members to review, but this is good to go.

Great news. Thanks for the help and feedback @rpkilby .

@rpkilby
Copy link
Member

rpkilby commented Oct 4, 2019

There should be another 3.10.x release before ~December (3.11 should roughly correspond with Django 3.0's release).

pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants