Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI: Use int64 format for large integers. #7018

Merged
merged 1 commit into from Nov 6, 2019
Merged

OpenAPI: Use int64 format for large integers. #7018

merged 1 commit into from Nov 6, 2019

Conversation

Kentalot
Copy link
Contributor

@Kentalot Kentalot commented Oct 24, 2019

Description

This fixes #7017 where we can produce a better openapi spec.

@hpaknia
Copy link

hpaknia commented Oct 24, 2019

Can someone review and merge?
CC @rpkilby @carltongibson

rest_framework/schemas/openapi.py Outdated Show resolved Hide resolved
@hpaknia
Copy link

hpaknia commented Oct 28, 2019

@rpkilby can you check. We are waiting for this.

@rpkilby
Copy link
Member

rpkilby commented Oct 28, 2019

Hi @hpaknia, waiting for @carltongibson to review, as schemas are more his domain.

@Kentalot
Copy link
Contributor Author

Kentalot commented Nov 1, 2019

Any updates on this? it's a relatively minor change.

Copy link
Collaborator

@carltongibson carltongibson left a comment

Yes, this looks sensible. Thanks very much!

@carltongibson carltongibson added this to the 3.11 Release milestone Nov 6, 2019
@carltongibson carltongibson changed the title Add better openapi spec generation for integer fields larger than 32bits OpenAPI: Use int64 format for large integers. Nov 6, 2019
@carltongibson carltongibson merged commit becb962 into encode:master Nov 6, 2019
1 check passed
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants