Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brotli support to use the brotlicffi package #1605

Merged
merged 3 commits into from Apr 28, 2021
Merged

Conversation

tomchristie
Copy link
Member

The brotlipy package has been superseded by the brotlicffi package.

See #1604

@tomchristie tomchristie added the refactor Issues and PRs related to code refactoring label Apr 28, 2021
@tomchristie tomchristie merged commit 760af43 into master Apr 28, 2021
@tomchristie tomchristie deleted the brotlicffi branch April 28, 2021 09:09
@tomchristie tomchristie mentioned this pull request Apr 29, 2021
@GeekDuanLian
Copy link

Hey, please follow the instructions in the brotlicffi document to import:

try:
    import brotlicffi as brotli
except ImportError:
    import brotli

Because it is difficult to install brotlicffi on cygwin, but Brotli is easy (existing software package).
So on cygwin, only can use import brotli.

@GeekDuanLian
Copy link

I suggest that the way to install dependencies is also in accordance with the brotlicffi documentation:

install_requires=[
    "brotli; platform_python_implementation == 'CPython'",
    "brotlicffi; platform_python_implementation != 'CPython'"
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues and PRs related to code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants