Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close responses when on cancellations occur during reading. #2156

merged 4 commits into from Mar 31, 2022


Copy link

@tomchristie tomchristie commented Mar 31, 2022

Based on #2148 but adding a test case which doesn't introduce sleep into our test suite.

  • Add failing test case.
  • Fix test case by switching to except BaseException: ... close ... raise throughout.

Closes #2139

@tomchristie tomchristie merged commit 3350d7e into master Mar 31, 2022
4 checks passed
@tomchristie tomchristie deleted the close-stream-on-base-exceptions branch March 31, 2022 12:41
@tomchristie tomchristie mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants