Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove converter from path when generating OpenAPI schema #1648

Merged
merged 6 commits into from Jun 28, 2022

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented May 24, 2022

To be more correct, I'd have to add the information about the type of the path parameter...

@@ -49,10 +50,11 @@ def get_endpoints(

for route in routes:
Copy link
Sponsor Member Author

@Kludex Kludex May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

route may not have path attribute, that's why the path =... is not here.

@Kludex Kludex requested a review from a team May 24, 2022
@Kludex Kludex added this to the Version 0.21.0 milestone May 27, 2022
@Kludex Kludex added the bug Something isn't working label May 27, 2022
@Kludex Kludex requested a review from adriangb Jun 9, 2022
@jvail
Copy link

jvail commented Jun 13, 2022

Hi, thank you for fixing this so quickly. Just a quick question: Why not put it into the next bug fix release e.g. 0.20.4 instead 0.21? Unfortunately I am a bit stuck continuing my code until this is fixed.

@Kludex
Copy link
Sponsor Member Author

Kludex commented Jun 18, 2022

Hi, thank you for fixing this so quickly. Just a quick question: Why not put it into the next bug fix release e.g. 0.20.4 instead 0.21? Unfortunately I am a bit stuck continuing my code until this is fixed.

Yeah, it can be on 0.20.4.

@Kludex Kludex removed this from the Version 0.21.0 milestone Jun 27, 2022
@Kludex Kludex mentioned this pull request Jun 27, 2022
1 task
Copy link
Member

@tomchristie tomchristie left a comment

Looks good, yup. One suggestion, but not a blocker.

@Kludex Kludex merged commit 795cf60 into master Jun 28, 2022
4 checks passed
@Kludex Kludex deleted the remove-converter-from-path-on-openapi-schema branch Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants