Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing docs #1686

Merged
merged 4 commits into from Jun 18, 2022
Merged

Add contributing docs #1686

merged 4 commits into from Jun 18, 2022

Conversation

aminalaee
Copy link
Member

@aminalaee aminalaee commented Jun 11, 2022

Fixes #1627

@aminalaee aminalaee marked this pull request as ready for review Jun 11, 2022
@aminalaee aminalaee requested a review from a team Jun 11, 2022
@aminalaee aminalaee added the documentation Project documentation label Jun 11, 2022
@Kludex Kludex added this to the Version 0.21.0 milestone Jun 12, 2022
docs/contributing.md Outdated Show resolved Hide resolved
- Release title `Version 0.13.3`
- Description copied from the changelog.

Once created this release will be automatically uploaded to PyPI.
Copy link
Sponsor Member

@Kludex Kludex Jun 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's just one more detail.

Not sure if good to mention, but to deploy to PyPI an encode/operator needs to approve the deployment.

Copy link
Member Author

@aminalaee aminalaee Jun 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think that would be more accurate. But I just kept it consistent with HTTPX, we can add it.

aminalaee and others added 2 commits Jun 18, 2022
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Kludex
Kludex approved these changes Jun 18, 2022
Copy link
Sponsor Member

@Kludex Kludex left a comment

Thanks @aminalaee 🙏

@Kludex Kludex merged commit 1225ae8 into master Jun 18, 2022
4 checks passed
@Kludex Kludex deleted the add-contributing-docs branch Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Project documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Contribution guidelines" to the documentation
2 participants