Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes on "filename" form-data field #1704

Merged
merged 7 commits into from Jun 27, 2022
Merged

Conversation

memsuser
Copy link
Contributor

@memsuser memsuser commented Jun 24, 2022

  • Added notes about RFC-7578 and "filename" form-data part field treatment by Starlette
  • Added small comment to file access example

* Added notes about RFC-7578 and "filename" form-data part field treatment by Starlette
* Added small comment to file access example
docs/requests.md Outdated Show resolved Hide resolved
Wrapped notes

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@adriangb
Copy link
Sponsor Member

adriangb commented Jun 25, 2022

This looks good to me!

@Kludex
Copy link
Sponsor Member

Kludex commented Jun 25, 2022

How does it look on mkdocs?

@adriangb
Copy link
Sponsor Member

adriangb commented Jun 25, 2022

image

docs/requests.md Outdated Show resolved Hide resolved
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@Kludex
Copy link
Sponsor Member

Kludex commented Jun 27, 2022

I don't think this note should be included before introducing the word UploadFile. 🤔

Can't we add this note by the end of the section?

@adriangb
Copy link
Sponsor Member

adriangb commented Jun 27, 2022

Yep that makes sense!

docs/requests.md Outdated Show resolved Hide resolved
adriangb and others added 2 commits Jun 27, 2022
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
docs/requests.md Outdated Show resolved Hide resolved
docs/requests.md Outdated Show resolved Hide resolved
Kludex
Kludex approved these changes Jun 27, 2022
@adriangb adriangb merged commit 92c1f1e into encode:master Jun 27, 2022
4 checks passed
@memsuser memsuser deleted the patch-1 branch Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants