Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wsproto version check expression #1342

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Jan 28, 2022

No description provided.

Comment on lines 17 to 19
assert version.parse(wsproto.__version__) > version.parse(
"0.13"
), "Need wsproto version 0.13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you probably mean >= here?

Also the "Need wsproto version 0.13" probably ought to be "Need wsproto version >= 0.13".

Suggested change
assert version.parse(wsproto.__version__) > version.parse(
"0.13"
), "Need wsproto version 0.13"
assert version.parse(wsproto.__version__) >= version.parse(
"0.13"
), "Need wsproto version >= 0.13"

Copy link
Sponsor Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I just wanted to compare the version right, but yeah, I can also fix it hahaha

Fix applied. I also took the opportunity to improve a little the message. What do you think?

@Kludex Kludex merged commit 02560a5 into encode:master Jan 28, 2022
Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
* Fix wsproto version check expression

* Update wsproto_impl.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants