Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage precision to 96.77% #1351

merged 3 commits into from Feb 1, 2022


Copy link
Sponsor Member

@Kludex Kludex commented Feb 1, 2022

"Aren't you being too pedantic?"

Not really... It's really bothersome having to regain the same coverage over and over again because PRs get merged without covering all of it. The idea here is to not regress anymore.

coverage doesn't support the precision argument on the CLI. I've created a PR to fix it: nedbat/coveragepy#1317. Until then, we should use the setup.cfg.

Copy link

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing.

Copy link
Sponsor Member Author

Kludex commented Feb 1, 2022

I may have a few rounds of commits to add pragma coverage conditional, so I can match the Ubuntu Python 3.8 coverage.

@Kludex Kludex changed the title Fix coverage precision to 96.83% Fix coverage precision to 96.77% Feb 1, 2022
@Kludex Kludex merged commit efdbe7a into encode:master Feb 1, 2022
Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
* Fix coverage precision to 96.83%

* Add conditional coverage rule

* Modify fail-under to check if 3.7 passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants