Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert stream interface #1355

merged 3 commits into from Feb 3, 2022


Copy link
Sponsor Member

@Kludex Kludex commented Feb 3, 2022

Supersedes #1307
On top of #1354

Copy link

@tomchristie tomchristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given #1226 (comment) I'm just going to defer to your judgement on this for now, @Kludex.

Copy link
Sponsor Member Author

Kludex commented Feb 3, 2022

I think this is a good thing. If we really wish to have a stream interface, then we can go back to this and study the plan of action in the future.

@Kludex Kludex merged commit 9722ca4 into encode:master Feb 3, 2022
Copy link

wlaub commented Feb 3, 2022

server = await loop.create_server( # type: ignore[call-overload]

create_server doesn't seem too happy about receiving path=config.uds

Traceback (most recent call last):
    File "/usr/lib/python3.8/asyncio/", line 44, in run
      return loop.run_until_complete(main)
    File "/usr/lib/python3.8/asyncio/", line 616, in run_until_complete
      return future.result()
    File "/snap/standalone-dev-env/x1/lib/python3.8/site-packages/uvicorn/", line 77, in serve
      await self.startup(sockets=sockets)
    File "/snap/standalone-dev-env/x1/lib/python3.8/site-packages/uvicorn/", line 137, in startup
      server = await loop.create_server(  # type: ignore[call-overload]
  TypeError: create_server() got an unexpected keyword argument 'path'

Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
* Revert "fix: move all data handle to protocol & ensure connection is closed (encode#1332)"

This reverts commit fc6e056.

* Revert stream interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants