Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop wsproto version checking #1359

merged 1 commit into from Feb 3, 2022


Copy link

Refs. #1358

I'm okay with us considering if we want to enforce strict version checking, but for right now let's just drop this.

(Because #1358 is a much worse thing for users to be bumping into than... "If you switch to wsproto, and you install an older version then websockets won't work properly.)

@tomchristie tomchristie mentioned this pull request Feb 3, 2022
2 tasks
@tomchristie tomchristie merged commit 49342ee into master Feb 3, 2022
@tomchristie tomchristie deleted the drop-wsproto-version-check branch February 3, 2022 15:24
@aminalaee aminalaee mentioned this pull request Feb 3, 2022
Kludex pushed a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants