Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility considering that people may have websockets<10.4 #1747

Merged
merged 2 commits into from Nov 1, 2022

Conversation

iudeen
Copy link
Contributor

@iudeen iudeen commented Oct 31, 2022

Please feel to close if its not worth it.

extra_headers=[
)
self.server_header = None
self.extra_headers = [
Copy link
Contributor Author

@iudeen iudeen Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests test_no_server_headers and test_multiple_server_header would fail in versions websockets<10.4.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@iudeen iudeen marked this pull request as ready for review October 31, 2022 19:16
Kludex
Kludex approved these changes Nov 1, 2022
Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested locally, and version websockets 10.3 works again with this PR. Can you confirm this was the intention?

@Kludex Kludex mentioned this pull request Nov 1, 2022
13 tasks
@iudeen
Copy link
Contributor Author

iudeen commented Nov 1, 2022

Yes! My intention was to not break users who have Websockets 10.3

@Kludex
Copy link
Sponsor Member

Kludex commented Nov 1, 2022

Cool! 👍

Feel free to merge it. :)

@iudeen iudeen merged commit c3aa2c0 into encode:master Nov 1, 2022
15 checks passed
@iudeen iudeen deleted the feat/old-version branch November 1, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants