Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for port being zero #1758

Merged
merged 3 commits into from Nov 10, 2022
Merged

Conversation

iudeen
Copy link
Contributor

@iudeen iudeen commented Nov 6, 2022

No description provided.

@Kludex Kludex changed the title Test Server start when port is 0 Add test case for port being zero Nov 10, 2022
@Kludex Kludex added the testing label Nov 10, 2022
@Kludex Kludex added this to the Version 0.20.0 milestone Nov 10, 2022
@Kludex
Copy link
Sponsor Member

Kludex commented Nov 10, 2022

I've tweaked the test a bit to make it a bit simpler to understand, as the goal is already achieved with that assertion.

Thanks 馃檹

Kludex
Kludex approved these changes Nov 10, 2022
@Kludex Kludex merged commit de0a23a into encode:master Nov 10, 2022
15 checks passed
@iudeen iudeen deleted the fix/test-port-zero branch November 10, 2022 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Test Coverage
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants