Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iocp drop #535

Merged
merged 3 commits into from
Dec 20, 2019
Merged

Iocp drop #535

merged 3 commits into from
Dec 20, 2019

Conversation

euri10
Copy link
Member

@euri10 euri10 commented Dec 20, 2019 •
edited by tomchristie
Loading

Closes #529

Removes iocp entirely and uses SelectorEventLoop for the asyncio auto default

@tomchristie
Copy link
Member

Great stuff - are you able to confirm that it resolves the issue?
Will probably issue this as a 0.11.0 release.

@euri10
Copy link
Member Author

euri10 commented Dec 20, 2019

Great stuff - are you able to confirm that it resolves the issue?
Will probably issue this as a 0.11.0 release.

I think so (#529 (comment)) but better 2 eyes than one !

@tomchristie tomchristie merged commit abd6870 into encode:master Dec 20, 2019
@euri10 euri10 deleted the iocp_drop branch December 20, 2019 12:49
@SK-415 SK-415 mentioned this pull request May 23, 2021
Closed
@jammer87 jammer87 mentioned this pull request Nov 20, 2021
Merged
@Kludex Kludex mentioned this pull request May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uvicorn reload fails on Windows and Python 3.8
2 participants
@euri10 @tomchristie