Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 0.11.6 #705

Merged
merged 3 commits into from Jul 17, 2020
Merged

Release version 0.11.6 #705

merged 3 commits into from Jul 17, 2020

Conversation

@tiangolo
Copy link
Member

@tiangolo tiangolo commented Jun 20, 2020

Release version 0.11.6.

I added notes in the changelog for the recent PRs after version 0.11.6: #660

All the changes are docs or bugfixes, so I just bumped the patch version.


Note: After/if merging, this would require adding a manual release in GitHub, including the new changelog items.

@tiangolo
Copy link
Member Author

@tiangolo tiangolo commented Jun 20, 2020

I'm not sure if there is a convention for the format of the messages in the changelog, I based it on the previous ones.

The current order in this PR is latest/newest PRs merged on top. The same way that latest version numbers are on top.

I'm not including PR numbers nor contributors, and not including small changes like typos.

@tomchristie let me know if I should adjust that or if you would prefer to change the info in the changelog somehow.

Loading

@tiangolo tiangolo requested a review from Jul 16, 2020
@tomchristie
Copy link
Member

@tomchristie tomchristie commented Jul 17, 2020

The current order in this PR is

Don't really mind about ordering here.

I'm [...] not including small changes like typos.

Indeed. We should only include behavioural changes in the release notes. Docs changes shouldn't really be in the release notes (since they're not actually part of the package release) nor should refactorings (since they ought to be transparent to the end user).

Loading

@tomchristie
Copy link
Member

@tomchristie tomchristie commented Jul 17, 2020

And thanks so much for cracking on with this! 😃

Loading

@tiangolo
Copy link
Member Author

@tiangolo tiangolo commented Jul 17, 2020

Perfect! Done ✔️

...I wish I could do more, I keep promising myself I'll do more here and on Starlette and then the other issues/PRs in FastAPI hold me there 🤦 😅

Loading

@tomchristie
Copy link
Member

@tomchristie tomchristie commented Jul 17, 2020

Don't sweat it, we're all doing what we can, where we can. 😃

Loading

@tomchristie tomchristie merged commit f623916 into encode:master Jul 17, 2020
3 checks passed
Loading
@tomchristie
Copy link
Member

@tomchristie tomchristie commented Jul 17, 2020

@tiangolo Ya fancy issuing the release? Otherwise I'm happy to sort that.

tag: 0.11.6
title: Version 0.11.6
description: * Fix overriding the root logger.

Loading

@tiangolo tiangolo deleted the version-0.11.6 branch Jul 17, 2020
@tiangolo
Copy link
Member Author

@tiangolo tiangolo commented Jul 17, 2020

Awesome, thanks! 🎉

Ya fancy issuing the release?

Sure thing! 🤩 🚀 ✔️

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants