Skip to content

Conversation

@Delta456
Copy link
Contributor

Fixes #924

@encore-cla
Copy link

encore-cla bot commented Dec 20, 2023

All committers have signed the CLA.

@eandre eandre self-requested a review December 20, 2023 14:37
@github-actions
Copy link

Test Results

    2 files  +       1  227 suites  +65   14m 7s ⏱️ - 11m 15s
722 tests +   163  719 ✔️ +   172  3 💤 +3  0  - 3 
722 runs   - 1 909  719 ✔️  - 1 900  3 💤 +3  0  - 3 

Results for commit a074c46. ± Comparison against base commit 3c5a103.

This pull request removes 39 and adds 202 tests. Note that renamed tests count towards both.
encr.dev/e2e-tests ‑ TestRun/encore_currentrequest
encr.dev/e2e-tests ‑ TestRun/et_override_user
encr.dev/e2e-tests ‑ TestRun/et_override_user_authdata
encr.dev/e2e-tests ‑ TestRun/experiment_local_secrets_override
encr.dev/e2e-tests ‑ TestRun/fallback_routes
encr.dev/e2e-tests ‑ TestRun/graceful_shutdown
encr.dev/e2e-tests ‑ TestRun/pubsub_method_handler
encr.dev/e2e-tests ‑ TestRun/pubsub_ref
test/svc ‑ TestEndToEndWithApp
test/svc ‑ TestEndToEndWithApp/basic_requests
…
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/echo
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/invalid
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/raw
encore.dev/appruntime/apisdk/api ‑ TestDescGeneratesTrace/unauthenticated
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/echo
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/invalid
encore.dev/appruntime/apisdk/api ‑ TestDesc_EndToEnd/unauthenticated
encore.dev/appruntime/apisdk/api ‑ TestRawEndpointOverflow
…

@eandre eandre merged commit 4928dab into encoredev:main Dec 23, 2023
@Delta456 Delta456 deleted the code_gen_add_optional branch December 23, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typescript generated client type error with slice optional query parameters

2 participants