forked from developer-portal/content
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Python docs #1
Open
encukou
wants to merge
2
commits into
master
Choose a base branch
from
update
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the list of Python versions. Remove sections for recently removed interpreters. Change the section order to put Multiple Pythons near the top, since this is one of the main selling points of Fedora wrt. Python. Warn that pip installs third-party software. Explain more clearly why virtual environments are preferred over Fedora packages for development. Only keep the name "virtualenv" for environments created by the actual `virtualenv` tool; otherwise switch "virtual environment" or just "environment". Update Flask docs to reflect best practice there. Add ESP32 to the MicroPython docs. And further rewordings and reorganization.
keszybz
reviewed
Oct 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
hroncok
reviewed
Oct 13, 2020
|
Added some suggestions and nit picks. As a whole, looking good, thanks! |
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the list of Python versions.
Remove sections for recently removed interpreters.
Change the section order to put Multiple Pythons near the top,
since this is one of the main selling points of Fedora wrt. Python.
Warn that pip installs third-party software.
Explain more clearly why virtual environments are preferred over
Fedora packages for development.
Only keep the name "virtualenv" for environments created by the actual
virtualenvtool; otherwise switch "virtual environment" or just "environment".Update Flask docs to reflect best practice there.
Add ESP32 to the MicroPython docs.
And further rewordings and reorganization.