Updated `package.json` deps to latest UglifyJS. #170

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@c7tincu

c7tincu commented Nov 25, 2012

UglifyJS < 1.3.2 produces broken minified code that affects Ender builds.
UglifyJS ≥ 1.3.2 solves this issue.

@ded

This comment has been minimized.

Show comment Hide comment
@ded

ded Nov 25, 2012

Owner

we probably should have just put it exactly to 1.3.0.

for something like this, i think it's probably safer for us to set a hard number, rather than using the >= operator. then update it in the future when we feel uglify is worth upgrading (and stable).

mind changing it to just say "uglify-js": "1.3.4"

Owner

ded commented Nov 25, 2012

we probably should have just put it exactly to 1.3.0.

for something like this, i think it's probably safer for us to set a hard number, rather than using the >= operator. then update it in the future when we feel uglify is worth upgrading (and stable).

mind changing it to just say "uglify-js": "1.3.4"

@c7tincu

This comment has been minimized.

Show comment Hide comment
@c7tincu

c7tincu Nov 25, 2012

Thank you, @ded.

Edit:
FWIW, mishoo is working for some time on UglifyJS2, which is already at 2.2.1 and this new thing is even more awesome (more efficient, source map support, etc).

c7tincu commented Nov 25, 2012

Thank you, @ded.

Edit:
FWIW, mishoo is working for some time on UglifyJS2, which is already at 2.2.1 and this new thing is even more awesome (more efficient, source map support, etc).

@amccollum

This comment has been minimized.

Show comment Hide comment
@amccollum

amccollum Feb 28, 2014

Contributor

I'm happy to report that ender@2.0.x now uses UglifyJS2.

Contributor

amccollum commented Feb 28, 2014

I'm happy to report that ender@2.0.x now uses UglifyJS2.

@amccollum amccollum closed this Feb 28, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment