Permalink
Commits on Jan 25, 2012
  1. Merge pull request #331 from BanzaiMan/master

    'deps' Rake task should not assume that 'gem' found on $PATH is the one that should be used
    rkh committed Jan 25, 2012
  2. Do not assume 'gem' on $PATH is the same as the one that this Ruby ru…

    …ntime should use. (Or, that 'gem' is found on $PATH at all.)
    BanzaiMan committed Jan 25, 2012
  3. Merge pull request #329 from TalentBox/parse_query-no-key-error

    Prevent error in Utils.parse_query/KeySpaceConstrainedParams when a key is nil
    raggi committed Jan 25, 2012
Commits on Jan 24, 2012
  1. Prevent error in Utils.parse_query/KeySpaceConstrainedParams when a k…

    …ey is nil
    
    Before this when parsing a query string or a cookie string, an error were
    raised because of the `key.size` in `KeySpaceConstrainedParams#[]=`.
    This caused an error when params contained something parsed as a `nil` key.
    JonathanTron committed Jan 24, 2012
Commits on Jan 23, 2012
  1. Merge pull request #326 from kyledrake/master

    Trivial readme fixes to 1.4.1 release history
    rkh committed Jan 23, 2012
  2. Multipart percentage fail, round 3, the final character. Fixes string…

    …s terminated with %. See #323. Revisit for 1.5.
    raggi committed Jan 23, 2012
  3. Prep for 1.4.1

    raggi committed Jan 23, 2012
  4. Merge remote-tracking branch 'thedarkone/nested_params_key_space2'

    * thedarkone/nested_params_key_space2:
      Rack::Utils#normalize_params should be ignorant of the provided params class.
      Correctly count the key space size for nested param queries.
    raggi committed Jan 23, 2012
  5. Correct multipart parser skips for cases where we have data that look…

    …s partially like it's percent-hex encoded
    raggi committed Jan 23, 2012
Commits on Jan 22, 2012
  1. Make the multipart filename unescaping just slightly more resilient t…

    …o potential use cases, as we don't have a way to get better real world coverage yet
    raggi committed Jan 22, 2012
  2. Multipart parsing now accepts filenames with unescaped percentages. T…

    …his could be improved.
    raggi committed Jan 22, 2012
  3. added Rack::Response::Helpers#method_not_allowed?

    Rack::File now returns 404 during illegal directory traversal, for backward compat
    Rack::File now returns 405 for illegal methods
    Rack::Cascade now defaults to catch 405 aswell as 404, for backward compat with 1.3.x in most common use cases
    raggi committed Jan 22, 2012
Commits on Jan 21, 2012
  1. Merge pull request #314 from goosmurf/master

    Fix crash when Rack::Session::Cookie value does not contain "--" delimiter
    raggi committed Jan 21, 2012
  2. Merge pull request #324 from rkyrychuk/patch-1

    Wrong version
    raggi committed Jan 21, 2012
  3. Merge pull request #325 from qertoip/patch-1

    Removed incorrect fragment of comment.
    raggi committed Jan 21, 2012
  4. Wrong version

    rkyrychuk committed Jan 21, 2012
Commits on Jan 20, 2012
Commits on Jan 18, 2012
  1. Add spec for #300. Appears to pass.

    raggi committed Jan 7, 2012
  2. Merge pull request #317 from brainopia/master

    A few stylistic changes
    rkh committed Jan 18, 2012
  3. Finish that Jose has started in 4defbe5

    I mean his work with extracting DEFAULT_OPTIONS[:key] and then
    forgetting to use it :)
    brainopia committed Jan 18, 2012
  4. Nitpicking

    brainopia committed Jan 18, 2012
Commits on Jan 17, 2012
  1. Merge pull request #315 from gogolok/fix_typo

    fix typo
    rkh committed Jan 17, 2012
  2. fix typo

    gogolok committed Jan 17, 2012
Commits on Jan 16, 2012
Commits on Jan 13, 2012
  1. Merge pull request #313 from josevalim/ensure_proxy

    Rack::BodyProxy should execute block even on failures.
    tenderlove committed Jan 13, 2012
  2. Rack::BodyProxy should execute block even on failures.

    In general, Rack frameworks are moving logic to close hooks in order
    to support async behavior increasing the chance an exception will
    happen on close. Most servers will actually die if there is an exception
    on close, but such exceptions can also happen in the test environment.
    In such cases, we can accidentally leave a mutex locked, a database
    connection not collected and so forth, therefore, we need to ensure
    the block is called regardless closing the body failed.
    josevalim committed Jan 13, 2012
Commits on Jan 12, 2012
  1. Merge pull request #312 from josevalim/assert_secure

    Assert the cookie is secure (there were no tests for this).
    tenderlove committed Jan 12, 2012
Commits on Jan 7, 2012
  1. Add missing spec coverage for when secrets do not match (ACHTUNG!)

    Fix Rack::Session::Cookie when old_secret or secret are not supplied.
    Always encode cookies with one of the two secret options, if provided, preferencing :secret
    Based on contribution from ciberch. Closes #304. Closes #299.
    raggi committed Jan 7, 2012
  2. Merge pull request #296 from jm3/patch-2

    ...except after c.
    raggi committed Jan 7, 2012