Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T24480 #353

Merged
merged 4 commits into from Nov 15, 2018
Merged

T24480 #353

merged 4 commits into from Nov 15, 2018

Conversation

cosimoc
Copy link
Contributor

@cosimoc cosimoc commented Nov 15, 2018

We will use this information to hide inactive windows from a hack
session in later commits.
They should not appear as separate windows.
Copy link
Contributor

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not merging yet, to give a chance to other reviewers.

Copy link
Contributor

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can probably be merged anyway without fixing my comment, but if there is a nicer way then it would be nice to get that in.

},

get cachedWindows() {
return this._cachedWindows.filter((win) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit weird in terms of expectations for the API user.

appIcon.cachedWindows = windowList;
appIcon.cachedWindows === windowList;  // -> false

@cosimoc
Copy link
Contributor Author

cosimoc commented Nov 15, 2018

@ptomato Updated

@ptomato
Copy link
Contributor

ptomato commented Nov 15, 2018

I think you amended the wrong commit, but the resulting code looks good to me.

They should not appear as separate windows.
They should not appear as separate windows.
@cosimoc
Copy link
Contributor Author

cosimoc commented Nov 15, 2018

Whoops, yes... re-amended the right commit :)

@cosimoc cosimoc merged commit 297abb1 into master Nov 15, 2018
@cosimoc cosimoc deleted the T24480 branch November 15, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants