New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T24480 #353
Conversation
We will use this information to hide inactive windows from a hack session in later commits.
They should not appear as separate windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Not merging yet, to give a chance to other reviewers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can probably be merged anyway without fixing my comment, but if there is a nicer way then it would be nice to get that in.
}, | ||
|
||
get cachedWindows() { | ||
return this._cachedWindows.filter((win) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit weird in terms of expectations for the API user.
appIcon.cachedWindows = windowList;
appIcon.cachedWindows === windowList; // -> false
@ptomato Updated |
I think you amended the wrong commit, but the resulting code looks good to me. |
They should not appear as separate windows.
They should not appear as separate windows.
Whoops, yes... re-amended the right commit :) |
https://phabricator.endlessm.com/T24480