From 70d653d8677d5da879b6ad866d9fac3a92aeccec Mon Sep 17 00:00:00 2001 From: Will Thompson Date: Tue, 24 Oct 2017 19:18:23 +0100 Subject: [PATCH] Assume errors are fatal iff we show no recover button This means we don't have to remember to update this switch when we add new recoverable errors. I don't really look at the exceptionTracking data but since it's here... --- src/endless/EndlessUsbToolDlg.cpp | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/endless/EndlessUsbToolDlg.cpp b/src/endless/EndlessUsbToolDlg.cpp index b0e6da6610f..ceb5a318b1c 100644 --- a/src/endless/EndlessUsbToolDlg.cpp +++ b/src/endless/EndlessUsbToolDlg.cpp @@ -1898,17 +1898,7 @@ void CEndlessUsbToolDlg::ErrorOccured(ErrorCause_t errorCause) else TrackEvent(_T("Failed"), ErrorCauseToStr(errorCause)); - bool fatal = FALSE; - switch (errorCause) { - case ErrorCause_t::ErrorCauseDownloadFailed: - case ErrorCause_t::ErrorCauseVerificationFailed: - case ErrorCause_t::ErrorCauseWriteFailed: - fatal = FALSE; - break; - default: - fatal = TRUE; - break; - } + bool fatal = recoverButtonMsgId == 0; Analytics::instance()->exceptionTracking(ErrorCauseToStr(errorCause), fatal); }