Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App run slow when fast scroll down when use branch "release/v2.0.0-RC4" or crash app in branch "release/v2.1.0" with url special #146

Closed
sonvp opened this issue Jan 19, 2017 · 10 comments

Comments

@sonvp
Copy link

sonvp commented Jan 19, 2017

Hi eneim.
I meet bug below when change url
"http://clips.vorwaerts-gmbh.de/big_buck_bunny.mp4"
into
"http://playready.directtaps.net/smoothstreaming/SSWSS720H264/SuperSpeedway_720.ism"

My device

  • Version 6.0.1
  • Sony Z3+ Dual
@eneim
Copy link
Owner

eneim commented Jan 19, 2017

Hi, do you have the crash log? Can you confirm your link works well with ExoPlayer?

@sonvp
Copy link
Author

sonvp commented Jan 19, 2017

ATAL EXCEPTION: main
                                                                   Process: forked.app.id.debug, PID: 2124
                                                                   java.lang.IndexOutOfBoundsException
                                                                       at com.google.android.exoplayer2.Timeline$1.getWindow(Timeline.java:107)
                                                                       at com.google.android.exoplayer2.Timeline.getWindow(Timeline.java:161)
                                                                       at com.google.android.exoplayer2.Timeline.getWindow(Timeline.java:148)
                                                                       at im.ene.toro.exoplayer2.ExoVideoView.releasePlayer(ExoVideoView.java:422)
                                                                       at im.ene.toro.exoplayer2.ExoVideoViewHolder.releasePlayer(ExoVideoViewHolder.java:75)
                                                                       at im.ene.toro.PlayerViewHelper.onDetachedFromWindow(PlayerViewHelper.java:78)
                                                                       at im.ene.toro.exoplayer2.ExoVideoViewHolder.onDetachedFromWindow(ExoVideoViewHolder.java:56)
                                                                       at im.ene.toro.ToroAdapter.onViewDetachedFromWindow(ToroAdapter.java:50)
                                                                       at im.ene.toro.ToroAdapter.onViewDetachedFromWindow(ToroAdapter.java:29)
                                                                       at android.support.v7.widget.RecyclerView.dispatchChildDetached(RecyclerView.java:6744)
                                                                       at android.support.v7.widget.RecyclerView$5.removeViewAt(RecyclerView.java:708)
                                                                       at android.support.v7.widget.ChildHelper.removeViewAt(ChildHelper.java:168)

@eneim
Copy link
Owner

eneim commented Jan 19, 2017

if you are working on a fork, please take a look at ExoVideoView line 42x (in the crash log) and fix the IndexOutOfBoundException <- work around for now. I will fix it later on my ongoing branch.

@sonvp
Copy link
Author

sonvp commented Jan 20, 2017

device-2017-01-20-173203

@eneim
Copy link
Owner

eneim commented Jan 21, 2017

@sonvp Can you checkout branch dev-v3 and try it again?

@sonvp
Copy link
Author

sonvp commented Jan 23, 2017

In branch "dev-v3" when I build app , I get error in class "ExoVideoView.java" .I have to change exoPlayer2Version = 'r2.1.1'==> exoPlayer2Version = 'r2.0.4'. And run app, I get log error below when fast scroll down or up with link url "http://playready.directtaps.net/smoothstreaming/SSWSS720H264/SuperSpeedway_720.ism"

Log Error:

java.lang.IndexOutOfBoundsException
                                                                       at com.google.android.exoplayer2.Timeline$1.getWindow(Timeline.java:107)
                                                                       at com.google.android.exoplayer2.Timeline.getWindow(Timeline.java:161)
                                                                       at com.google.android.exoplayer2.Timeline.getWindow(Timeline.java:148)
                                                                       at im.ene.toro.exoplayer2.ExoVideoView.releasePlayer(ExoVideoView.java:421)
                                                                       at im.ene.toro.exoplayer2.ExoVideoViewHolder.releasePlayer(ExoVideoViewHolder.java:75)
                                                                       at im.ene.toro.PlayerViewHelper.onDetachedFromWindow(PlayerViewHelper.java:78)
                                                                       at im.ene.toro.exoplayer2.ExoVideoViewHolder.onDetachedFromWindow(ExoVideoViewHolder.java:56)
                                                                       at im.ene.toro.ToroAdapter.onViewDetachedFromWindow(ToroAdapter.java:50)
                                                                       at im.ene.toro.ToroAdapter.onViewDetachedFromWindow(ToroAdapter.java:29)

@eneim
Copy link
Owner

eneim commented Jan 23, 2017

Hmm, @sonvp it is weird, can you make a clean clone for dev-v3? I have updated ExoVideoView to match latest ExoPlayer update though. Please clear stuff and rebuild to prevent cache :D.

@sonvp
Copy link
Author

sonvp commented Jan 23, 2017

I had rebuild project but still not solve problem . If i not change exoPlayer2Version = 'r2.0.4' , it will show error :

  • Class 'ComponentListener' must either be declared abstract or implement abstract method 'onTracksChanged(TrackGroupArray, TrackSelectionArray)' in 'EventListener
  • Cannot resolve constructor 'DefaultTrackSelector(android.os.Handler, com.google.android.exoplayer2.trackselection.TrackSelection.Factory)'.

@eneim
Copy link
Owner

eneim commented Jan 23, 2017

@sonvp here is server version of dev-v3 ExoVideoView: link which already has "onTracksChanged" implemented. Can you confirm the content? Please make sure you are on sync with origin or upstream dev-v3 branch :-?

@sonvp
Copy link
Author

sonvp commented Jan 23, 2017

Thank @eneim . I think mistake something .I checkout again branch "dev-v3" and test app. I not see errors above.
Thank again.

@eneim eneim closed this as completed Feb 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants