From 427f4a89b666501871abdacdb918c05410da84d3 Mon Sep 17 00:00:00 2001 From: John Henderson Date: Mon, 21 Jun 2021 14:51:29 -0700 Subject: [PATCH] fix(createClaimRequest): use subjectAgreement SWTCH-1061 Rename agreement to subjectAgreement in IClaimRequest to align with cache-server --- src/iam.ts | 4 ++-- test/claimsTests/enrollmentClaimsTests.ts | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/iam.ts b/src/iam.ts index 7b8c9373..8d6eab3d 100644 --- a/src/iam.ts +++ b/src/iam.ts @@ -84,7 +84,7 @@ export interface IMessage { export interface IClaimRequest extends IMessage { token: string; registrationTypes: RegistrationTypes[]; - agreement?: string; + subjectAgreement?: string; } export interface IClaimIssuance extends IMessage { @@ -1500,7 +1500,7 @@ export class IAM extends IAMBase { if (!version) { throw new Error(ERROR_MESSAGES.ONCHAIN_ROLE_VERSION_NOT_SPECIFIED); } - message.agreement = await this.approveRolePublishing({ subject, role, version }); + message.subjectAgreement = await this.approveRolePublishing({ subject, role, version }); } if (this._natsConnection) { diff --git a/test/claimsTests/enrollmentClaimsTests.ts b/test/claimsTests/enrollmentClaimsTests.ts index 4b1221db..75cb9f63 100644 --- a/test/claimsTests/enrollmentClaimsTests.ts +++ b/test/claimsTests/enrollmentClaimsTests.ts @@ -113,7 +113,7 @@ export function enrollmentClaimsTests() { expect(message).toHaveProperty("token"); expect(message).toMatchObject({ requester: subjectDID, registrationTypes }); - const { id, agreement: subjectAgreement, token } = message; + const { id, subjectAgreement, token } = message; await staticIssuerIam.issueClaimRequest({ id, registrationTypes, @@ -148,7 +148,7 @@ export function enrollmentClaimsTests() { }); let [, encodedMsg] = publish.mock.calls.pop(); let message = jsonCodec.decode(encodedMsg); - let { agreement: subjectAgreement, token, id } = message; + let { subjectAgreement, token, id } = message; await staticIssuerIam.issueClaimRequest({ id, requester: dynamicIssuerDID, token, registrationTypes, subjectAgreement }); expect(await claimManager.hasRole(addressOf(dynamicIssuerDID), namehash(`${roleName1}.${root}`), version)); @@ -160,7 +160,7 @@ export function enrollmentClaimsTests() { }); ([, encodedMsg] = publish.mock.calls.pop()); message = jsonCodec.decode(encodedMsg); - ({ agreement: subjectAgreement, token, id } = message); + ({ subjectAgreement, token, id } = message); await dynamicIssuerIam.issueClaimRequest({ id, requester: subjectDID, token, registrationTypes, subjectAgreement }); expect(await claimManager.hasRole(addressOf(subjectDID), namehash(`${roleName2}.${root}`), version));