New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doi 710 migrate origin lerna monorepo to rush #2077
Doi 710 migrate origin lerna monorepo to rush #2077
Conversation
…OI-710-migrate-origin-lerna-monorepo-to-rush
5b2590c
to
2272ff2
Compare
@royki @kosecki123 I'll remove the "Build containers" action as a part of the tests once the PR is approved. It currently makes the build 11 min longer. |
No. please remove. Also, please keep original Dockerfiles, these based on the NPM installation. The idea is to enable nightly canary releases and use those Dockerfiles to deploy from packages. |
Alright, will do. I didn't remove any Dockerfiles, just added the |
@JosephBagaric Please squash and merge instead of typical merge, too many useless commit messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfiles should not use NPM installs.
@kosecki123 is the goal to remove Lerna entirely from the monorepo? |
…://github.com/energywebfoundation/origin into DOI-710-migrate-origin-lerna-monorepo-to-rush
This reverts commit 5227d9d.
This PR adds rush as monorepo management tool, next to lerna which is still used for NPM releases.