Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doi 710 migrate origin lerna monorepo to rush #2077

Merged
merged 92 commits into from Mar 26, 2021

Conversation

royki
Copy link
Member

@royki royki commented Feb 24, 2021

This PR adds rush as monorepo management tool, next to lerna which is still used for NPM releases.

@kosecki123 kosecki123 marked this pull request as ready for review March 1, 2021 10:31
@kosecki123 kosecki123 force-pushed the DOI-710-migrate-origin-lerna-monorepo-to-rush branch from 5b2590c to 2272ff2 Compare March 2, 2021 08:54
@josipbagaric
Copy link
Contributor

josipbagaric commented Mar 25, 2021

@royki @kosecki123 I'll remove the "Build containers" action as a part of the tests once the PR is approved. It currently makes the build 11 min longer.

@kosecki123
Copy link
Contributor

@royki @kosecki123 Do we want to keep the "Build containers" action as a part of the tests?
It makes the build 11 min longer.

No. please remove. Also, please keep original Dockerfiles, these based on the NPM installation. The idea is to enable nightly canary releases and use those Dockerfiles to deploy from packages.

@josipbagaric
Copy link
Contributor

@royki @kosecki123 Do we want to keep the "Build containers" action as a part of the tests?
It makes the build 11 min longer.

No. please remove. Also, please keep original Dockerfiles, these based on the NPM installation. The idea is to enable nightly canary releases and use those Dockerfiles to deploy from packages.

Alright, will do. I didn't remove any Dockerfiles, just added the Dockerfile.local ones.

@kosecki123
Copy link
Contributor

@JosephBagaric Please squash and merge instead of typical merge, too many useless commit messages.

Copy link
Contributor

@kosecki123 kosecki123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfiles should not use NPM installs.

@josipbagaric
Copy link
Contributor

@kosecki123 is the goal to remove Lerna entirely from the monorepo?
This PR still uses some Lerna commands. I'm thinking of removing them

@josipbagaric josipbagaric merged commit 5227d9d into master Mar 26, 2021
josipbagaric added a commit that referenced this pull request Mar 26, 2021
@josipbagaric josipbagaric deleted the DOI-710-migrate-origin-lerna-monorepo-to-rush branch March 26, 2021 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants