Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed scale of the grid so that it lines up with positioning #578

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

jf-kelly
Copy link
Contributor

@jf-kelly jf-kelly commented Jun 7, 2022

This fix is in relation to issue #577
The only change I made was changing the scale of the grid in View.js so that now when the user sets the position of an object, it lines up with the grid lines.
Example of change:
2022-06-07 (1)

@jf-kelly jf-kelly requested a review from a team June 7, 2022 17:22
@bryanmontalvan
Copy link
Member

@jf-kelly Could you show this new change to us in the next meeting?

Copy link
Member

@bryanmontalvan bryanmontalvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great work John!

@bryanmontalvan bryanmontalvan added this to the Version 3.2.0 milestone Jun 28, 2022
@bryanmontalvan bryanmontalvan added Frontend Issues being caused via the frontend Minor bug labels Jun 28, 2022
@bryanmontalvan bryanmontalvan merged commit 8710a60 into engaging-computing:dev Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Issues being caused via the frontend Minor bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants