From 1ce85bec2f4e8a558ed468f13aa42fb15ed38c9d Mon Sep 17 00:00:00 2001 From: Nathan Rogers Date: Wed, 11 Dec 2019 21:03:12 -0800 Subject: [PATCH] [flutter_runner] Enable Skia tracing by default on Fuchsia (#13457) Since Flutter tracing is wired up to Fuchsia system level tracing (and that includes Skia tracing within Flutter), it makes more sense to enable Skia tracing by default on Fuchsia, and to control Flutter Skia tracing, rely on whether Fuchsia system tracing is enabled, in progress, and contains the "skia" category. --- shell/platform/fuchsia/flutter/component.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/shell/platform/fuchsia/flutter/component.cc b/shell/platform/fuchsia/flutter/component.cc index 2cbd33586e1d..e1188f44a99d 100644 --- a/shell/platform/fuchsia/flutter/component.cc +++ b/shell/platform/fuchsia/flutter/component.cc @@ -316,9 +316,8 @@ Application::Application( settings_.observatory_host = "127.0.0.1"; #endif - // Set this to true to enable category "skia" trace events. - // TODO(PT-145): Explore enabling this by default. - settings_.trace_skia = false; + // Controls whether category "skia" trace events are enabled. + settings_.trace_skia = true; settings_.icu_data_path = "";