From 3c1c3e26d4e96d8f6f7a313b5e609da3c164378d Mon Sep 17 00:00:00 2001 From: liyuqian Date: Tue, 7 Apr 2020 16:44:57 -0700 Subject: [PATCH] Add comments to build_and_test_linux_unopt_debug (#17567) Clarify that the test depends on the framework repo. It may fail if the framework repo is broken, so the engine committer don't need to be in panic. --- .cirrus.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.cirrus.yml b/.cirrus.yml index b2942ded3b18..c58fcb3b3ac6 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -74,6 +74,9 @@ task: test_host_script: | cd $ENGINE_PATH/src ./flutter/testing/run_tests.sh host_release + + # The following test depends on Flutter framework repo. It may fail if the + # framework repo is currently broken. - name: build_and_test_linux_unopt_debug compile_host_script: | cd $ENGINE_PATH/src @@ -97,6 +100,9 @@ task: mkdir -p $FRAMEWORK_PATH cd $FRAMEWORK_PATH git clone https://github.com/flutter/flutter.git + verify_framework_script: + - echo "Checking that the framework Cirrus test is not currently broken..." + - curl -s https://api.cirrus-ci.com/github/flutter/flutter.json | grep -q passing test_web_script: | cd $FRAMEWORK_PATH/flutter/dev/integration_tests/web ../../../bin/flutter config --local-engine=host_debug_unopt --no-analytics --enable-web